Skip to content

Add BigQuery dialect #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

komukomo
Copy link
Contributor

@komukomo komukomo commented May 9, 2022

We need the BigQuery dialect to support special syntax such as trailing commas, UNION DISTINCT, identifier detection, etc.
To simplify each PR, this PR includes only dialect support, and we plan to implement other syntax in later PRs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2297312014

  • 36 of 36 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 90.468%

Totals Coverage Status
Change from base Build 2296274900: 0.05%
Covered Lines: 8286
Relevant Lines: 9159

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @komukomo

@alamb alamb merged commit 97a148a into apache:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants